Mark failed deal data transfer as failed and stop restarting it #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
en0ma
changed the title
failed
en0ma
changed the title
failed
alvin-reyes
reviewed
Jul 1, 2022
| if loc == "local" { | ||
| st, err := cm.FilClient.TransferStatus(ctx, &chanid) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if util.TransferTerminated(st) { | ||
| return fmt.Errorf("deal in database as being in progress, but data transfer is terminated: %d", st.Status) | ||
| if err := cm.DB.Model(contentDeal{}).Where("id = ?", dealID).UpdateColumns(map[string]interface{}{ |
There was a problem hiding this comment.
Do we need to store the status if we're going to restart the transfer anyway (line 847)? Just concern that we have a DB call here to update it to failed only to do another restart transfer which technically will be "in-progress".
There was a problem hiding this comment.
look closely, if TransferTerminated (meaning is it useless to restart), we mark it as failed and return the deal in database is in progress, but data transfer is terminated error (line 847 wont get called). The marking is useful in that, whenever estuary is restarted or restart is trigger, deals marked as failed will not be picked from db - improved db calls and less error logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark failed deal data transfer as
failedso it won't be picked up perpetually for retry.closes #305