[Breaking change] change handleGetCollectionContents #341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested as follows:
Created a collection
Added file "a" to
/test1/test2/test3
, and then fetched contents at/
,/test1
,/test1/test2
and/test1/test2/test3
Then added a file "b" at
/test1/test2
, and again fetched contents.I think the behaviour is generally what we want. There are a couple of things I still want to work out:
/abc/def/def
r.Type
? I don't think we actually set that when we add content.Ideally I would at least like to fix (1) in this PR. We can handle (2) separately.on second thoughts, would like to merge this as soon as possible.