Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change more log levels to reduce noise #344

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Conversation

en0ma
Copy link
Contributor

@en0ma en0ma commented Jul 21, 2022

No description provided.

@en0ma en0ma requested review from anjor and alvin-reyes July 21, 2022 09:01
@en0ma en0ma changed the title Change more log levels Change more log levels to reduce noise Jul 21, 2022
@@ -1484,7 +1484,7 @@ func (s *Server) handleGetContentByCid(c echo.Context) error {
return err
}

var out []getContentResponse
out := make([]getContentResponse, 0)
Copy link
Contributor Author

@en0ma en0ma Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this change so when a cid is not estuary, it does not return null, but an empty array

Screenshot 2022-07-21 at 10 01 59

VS

Screenshot 2022-07-21 at 10 03 57

@anjor
Copy link
Contributor

anjor commented Jul 21, 2022

lgtm

@anjor anjor merged commit 32fb57d into master Jul 21, 2022
@alvin-reyes alvin-reyes deleted the change-more-log-levels branch July 27, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants