miner selection improvements - part 1 (extract miner logic into a separate package) #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
en0ma
changed the title
en0ma
changed the title
en0ma
changed the title
|
Looks good! Much cleaner with the |
alvin-reyes
reviewed
Nov 17, 2022
jcace
reviewed
Nov 18, 2022
jcace
approved these changes
Nov 18, 2022
alvin-reyes
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
LGTM
a few things to note:
- we should abstract the miner selection.
- think about adding geolocation (miners <> shuttle <> users)
- reputation to include number of deals, location, age, uptime (heartbeat mechanism)
We can do this on another set of PRs.
Great work as usual @en0ma!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The miner selection improvement will happen in multiple PRs to make code review easy.
This first PR makes no miner selection behavior changes, it basically extracted the miner logic into a separate package.
A follow-up PR will bring the actual selection behavior changes and it will be easy to code review as there will be less distraction from moving things around
Verification
I have verified deals are made, and current miner behavior was unchanged