Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Correct response type for AddCar API. #539

Merged
merged 1 commit into from
Nov 18, 2022
Merged

docs: Correct response type for AddCar API. #539

merged 1 commit into from
Nov 18, 2022

Conversation

simonwo
Copy link
Contributor

@simonwo simonwo commented Nov 17, 2022

Without this, the estuary-clients don't understand how to parse the response from the Add CAR API, so that API doesn't work.

alvin-reyes
alvin-reyes approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@alvin-reyes alvin-reyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvin-reyes alvin-reyes merged commit 5a9929b into application-research:dev Nov 18, 2022
@simonwo simonwo deleted the update-content-swagger-docs branch November 18, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvin-reyes alvin-reyes alvin-reyes approved these changes

@snissn snissn Awaiting requested review from snissn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonwo @alvin-reyes