Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properly handle proxy upload response content type #544

Merged
merged 1 commit into from
Nov 18, 2022
Merged

properly handle proxy upload response content type #544

merged 1 commit into from
Nov 18, 2022

Conversation

en0ma
Copy link
Contributor

@en0ma en0ma commented Nov 18, 2022

closes #540

verification

  • success response (before) - plaintext

Screenshot 2022-11-18 at 14 08 35

  • success response (after) - json

Screenshot 2022-11-18 at 14 24 19

  • failed response (before) - plaintex

Screenshot 2022-11-18 at 14 37 47

  • failed response (after) - json

Screenshot 2022-11-18 at 14 27 33

alvin-reyes
alvin-reyes approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@alvin-reyes alvin-reyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@en0ma en0ma merged commit 8a23455 into dev Nov 18, 2022
@en0ma en0ma deleted the chore/properly-handle-proxy-upload-response-content-type branch November 18, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvin-reyes alvin-reyes alvin-reyes approved these changes

@anjor anjor Awaiting requested review from anjor

@gmelodie gmelodie Awaiting requested review from gmelodie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@en0ma @alvin-reyes