Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add put / get endpoints #546

Merged
merged 2 commits into from
Nov 19, 2022
Merged

Add put / get endpoints #546

merged 2 commits into from
Nov 19, 2022

Conversation

10d9e
Copy link
Contributor

@10d9e 10d9e commented Nov 19, 2022

Added convenience methods for adding/retrieving content with

  • put - a synonym for content/add, and
  • get - which redirects to the estuary gateway as /gw/ipfs/{cid}

image

image

@snissn
Copy link
Contributor

snissn commented Nov 19, 2022

love this, the api is so confusing :)

@10d9e 10d9e requested a review from snissn November 19, 2022 19:36
jimmylee
jimmylee approved these changes Nov 19, 2022
View reviewed changes
Copy link
Contributor

@jimmylee jimmylee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is such a better API

@10d9e 10d9e merged commit 4fe510e into dev Nov 19, 2022
@en0ma en0ma deleted the add-put-get-endpoints branch November 20, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmylee jimmylee jimmylee approved these changes

@alvin-reyes alvin-reyes Awaiting requested review from alvin-reyes

@gmelodie gmelodie Awaiting requested review from gmelodie

@snissn snissn Awaiting requested review from snissn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@10d9e @snissn @jimmylee