Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estuary gw retrieval #548

Merged
merged 7 commits into from
Nov 21, 2022
Merged

Estuary gw retrieval #548

merged 7 commits into from
Nov 21, 2022

Conversation

anjor
Copy link
Contributor

@anjor anjor commented Nov 21, 2022

This is potentially a contentious change. Perhaps we should keep the old retrieval url field as is, and just add the estuary one. In any case, would love feedback.

@anjor
Copy link
Contributor Author

anjor commented Nov 21, 2022

I would also be ok with switching to estuary gw instead of dweb if folks are comfortable with that.

10d9e
10d9e previously approved these changes Nov 21, 2022
Copy link
Contributor

@10d9e 10d9e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alvin-reyes
alvin-reyes previously approved these changes Nov 21, 2022
Copy link
Contributor

@alvin-reyes alvin-reyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anjor anjor dismissed stale reviews from alvin-reyes and 10d9e via a65017a November 21, 2022 16:08
Copy link
Contributor

@alvin-reyes alvin-reyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anjor anjor merged commit 115fe68 into dev Nov 21, 2022
@anjor anjor deleted the anjor/estuary-gw-retrieval branch November 21, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants