create sharded dir in shuttle for shuttle contents #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
en0ma
changed the title
neelvirdy
reviewed
Nov 23, 2022
neelvirdy
reviewed
Nov 23, 2022
neelvirdy
reviewed
Nov 23, 2022
neelvirdy
reviewed
Nov 23, 2022
alvin-reyes
reviewed
Nov 24, 2022
alvin-reyes
reviewed
Nov 24, 2022
alvin-reyes
reviewed
Nov 24, 2022
alvin-reyes
reviewed
Nov 24, 2022
en0ma
deleted the
chore/generate-sharded-dir-in-shuttle-for-shuttle-contents
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves shuttle content aggregation to shuttle (its faster, cleaner, and more deterministic).
I tested the previous implementation where aggregation happens on primary, for shuttle contents, sharded dir requires bitswap so it takes time.
verification
I have tested this, it works as expected - super fast!