Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/peering-peers endpoint #616

Open
wants to merge 5 commits into
base: api-v2
Choose a base branch
from
Open

/peering-peers endpoint #616

wants to merge 5 commits into from

Conversation

toastts
Copy link
Contributor

@toastts toastts commented Nov 30, 2022

moved the peers-related functionality into the /peering-peers endpoint, added the admin auth to the route, updated the godocs

resolves #577

@gmelodie gmelodie added the APIv2 API v2 changes label Nov 30, 2022
@gmelodie gmelodie changed the title /peering-peers endpoint api-v2 /peering-peers endpoint Nov 30, 2022
gmelodie
gmelodie suggested changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@gmelodie gmelodie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

handlers.go Outdated Show resolved Hide resolved
@toastts @gmelodie
change echo group name for clarity
86c49e1 
Co-authored-by: Gabriel Cruz <8129788+gmelodie@users.noreply.github.com>
@toastts
Copy link
Contributor Author

toastts commented Dec 20, 2022

@gmelodie forgot to ping, this PR should be ready now; lmk if there's any more changes

gmelodie
gmelodie suggested changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@gmelodie gmelodie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is for APIv2, could you move these to /api/v2/api.go and /api/v2/handlers.go instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmelodie gmelodie gmelodie requested changes

@alvin-reyes alvin-reyes Awaiting requested review from alvin-reyes

@neelvirdy neelvirdy Awaiting requested review from neelvirdy

Assignees

@toastts toastts

Labels
APIv2 API v2 changes
Projects
Estuary Engineering Task Board
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toastts @gmelodie