Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move flags into flags.go and extract Setup/Run logic #672

Merged
merged 4 commits into from
Jan 20, 2023
Merged

Move flags into flags.go and extract Setup/Run logic #672

merged 4 commits into from
Jan 20, 2023

Conversation

neelvirdy
Copy link
Contributor

@neelvirdy neelvirdy commented Dec 6, 2022 •
edited
Loading

this is a small start to making estuary setup and run cmds accessible in tests, as well as de-bloating main.go

  1. move flags into a flags.go file
  2. move bulk of Setup and Run logic out of action and into dedicated methods (for ./estuary setup and ./estuary cmds)

@neelvirdy neelvirdy marked this pull request as draft December 6, 2022 18:08
@neelvirdy neelvirdy changed the title gingkoNvirdy/enable start estuary in tests Enable start estuary in tests Dec 6, 2022
@neelvirdy neelvirdy force-pushed the nvirdy/enable-start-estuary-in-tests branch from 6fff719 to b08648e Compare December 8, 2022 19:15
@neelvirdy neelvirdy force-pushed the nvirdy/enable-start-estuary-in-tests branch from b08648e to 2199a6c Compare January 19, 2023 20:09
@neelvirdy neelvirdy changed the title Enable start estuary in tests Move flags into flags.go and extract Setup/Run logic Jan 19, 2023
@neelvirdy neelvirdy marked this pull request as ready for review January 19, 2023 20:11
en0ma
en0ma approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@en0ma en0ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neelvirdy neelvirdy merged commit d3edc8f into application-research:dev Jan 20, 2023
@neelvirdy neelvirdy deleted the nvirdy/enable-start-estuary-in-tests branch January 20, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@en0ma en0ma en0ma approved these changes

@gmelodie gmelodie Awaiting requested review from gmelodie

@alvin-reyes alvin-reyes Awaiting requested review from alvin-reyes

@anjor anjor Awaiting requested review from anjor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neelvirdy @en0ma @gmelodie