Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add /content/contents endpoint, include PinningStatus in Content #772

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Add /content/contents endpoint, include PinningStatus in Content #772

merged 3 commits into from
Dec 14, 2022

Conversation

neelvirdy
Copy link
Contributor

  1. Add /content/contents endpoint that is like /content/stats but returns actual Contents instead of statsResp
  2. Include PinningStatus in the Content struct so it is accessible from both the /content/contents endpoint and the /content/staging-zones/:staging_zone/contents endpoint
  3. Adds "offloaded" PinningStatus

enables application-research/estuary-www#136

@neelvirdy neelvirdy mentioned this pull request Dec 14, 2022
Merged
@neelvirdy neelvirdy requested a review from en0ma December 14, 2022 05:16
en0ma
en0ma approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@en0ma en0ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@en0ma en0ma merged commit 91c261b into application-research:dev Dec 14, 2022
@neelvirdy neelvirdy deleted the nvirdy/contents-resp branch December 20, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@en0ma en0ma en0ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neelvirdy @en0ma