Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call the queueManager checker from a go routine #773

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Conversation

alvin-reyes
Copy link
Contributor

No description provided.

@alvin-reyes alvin-reyes marked this pull request as ready for review December 14, 2022 05:32
Copy link
Contributor

@10d9e 10d9e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@en0ma
Copy link
Contributor

en0ma commented Dec 14, 2022

Nice! additionally, we should only add to the queue if the size is above min deal size. No point adding anything less. Lastly, we should not be using this queue at all, but that will come with the content improvement work

@alvin-reyes alvin-reyes merged commit 5e29e7b into dev Dec 14, 2022
@en0ma en0ma deleted the pm-check branch December 14, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants