Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup postman tests #850

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Cleanup postman tests #850

wants to merge 1 commit into from

Conversation

gmelodie
Copy link
Contributor

@gmelodie gmelodie commented Jan 9, 2023

  • simplify script
  • remove foo file
  • better error messages (todo)

@gmelodie gmelodie requested review from snissn and jcace January 9, 2023 21:35
@gmelodie gmelodie self-assigned this Jan 9, 2023
@jcace
Copy link
Contributor

jcace commented Jan 9, 2023

looks good! will definitely be good to process the errors better, raw axios dump is hard to figure out what's going on. Not entirely sure where to do that though, any idea?

@snissn
Copy link
Contributor

snissn commented Jan 10, 2023

Awesome! Only failure is that we are currently expecting a file named "foo" with content "foo" in the folder. I think we also use it's cid somewhere so can we revert the git rm foo part of the commit? @gmelodie

@@ -1 +0,0 @@
foo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to put this file back as it's used for the tests 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants