Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the pinning api filtering #992

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix the pinning api filtering #992

wants to merge 2 commits into from

Conversation

ohmpatel1997
Copy link

@ohmpatel1997 ohmpatel1997 commented Jul 14, 2023 •
edited
Loading

  • This PR fixes the status based filtering on the list pins api.

@LucRoy LucRoy added the Improvement Improve a feature or the codebase label Jul 19, 2023
@LucRoy
Copy link
Contributor

LucRoy commented Jul 19, 2023

I'm wondering if we shouldn't add either a new endpoint or new query param for this. We want to make sure we don't break any backward compatibility. @alvin-reyes what do you think?

@ohmpatel1997
Copy link
Author

make sure we don't break any backw

I think the previous logic was flawed in itself. So even if someone was using it must be giving them the wrong results. also it wont break any existing api's schema, since we are not chaning any query param types.

@ohmpatel1997
Copy link
Author

Hi @LucRoy can we please get this PR in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvin-reyes alvin-reyes Awaiting requested review from alvin-reyes

@LucRoy LucRoy Awaiting requested review from LucRoy

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Improvement Improve a feature or the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ohmpatel1997 @LucRoy