Adding support for embedding Service Binding definition in RuntimeComponent CR #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navidsh
changed the title
navidsh
force-pushed
the
embedded
branch
4 times, most recently
from
780547c to
88d3929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?:
bindings.embeddedtoRuntimeComponenttype as a free-form YAML. This allows creating SBR while not relying on the SBR CRD since there are going to be changes in GVK and well asspecfields.Does this PR introduce a user-facing change? To be delivered in a separate PR
CHANGELOG.mdWhich issue(s) this PR fixes: #100