Dont create deployment without a pull secret #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leochr
reviewed
Mar 14, 2022
| if instance.Spec.ServiceAccountName != nil && *instance.Spec.ServiceAccountName != "" { | ||
| saName = *instance.Spec.ServiceAccountName | ||
| } | ||
| saErr := appstacksutils.PullSecretExists(saName, instance.Namespace, r.GetClient()) |
There was a problem hiding this comment.
To minimize the amount of changes needed for each controller, it'll be good if the above logic to determine the service account name is also moved into the util method. The variable ba (of type common.BaseComponent) can be passed instead of saName and instance.Namespace. They can be retrieved from ba along with CR fields (i.e. ba.GetServiceAccountName()). Util method CustomizeRoute is a good reference. It's fine to pass in client along with ba.
Suggested name for the method: ServiceAccountPullSecretExists
The cluster automatically creates pull secrets for the service account. This can take a while. Sometimes, the controller creates the deployment before the pull secret is created. This causes the pods to go into an image pull backoff loop. Check that the pull secret exists before the deployment is created, to prevent this
|
@leochr review comments addressed, pls could you take another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cluster automatically creates pull secrets for the service account.
This can take a while.
Sometimes, the controller creates the deployment before the pull secret
is created. This causes the pods to go into an image pull backoff loop.
Check that the pull secret exists before the deployment is created, to
prevent this
This will help us to fix issue OpenLiberty/open-liberty-operator#312