Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for secrets only if service account pull secrets exist #377

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Check for secrets only if service account pull secrets exist #377

merged 1 commit into from
Apr 18, 2022

Conversation

halim-lee
Copy link
Collaborator

What this PR does / why we need it?:

  • The operator checks if secret resource exists even if service account does not have pull secret added. Check only if pull secret is added to service account.

Does this PR introduce a user-facing change?

  • User guide
  • CHANGELOG.md

Which issue(s) this PR fixes:

Related: OpenLiberty/open-liberty-operator#340

@halim-lee halim-lee requested a review from leochr April 18, 2022 21:24
leochr
leochr approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@halim-lee Looks good. Thanks

@leochr leochr merged commit 1d5d995 into main Apr 18, 2022
This was referenced Jun 6, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leochr leochr leochr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@halim-lee @leochr