Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding OpenShift specific annotations #54

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Adding OpenShift specific annotations #54

merged 2 commits into from
Mar 18, 2020

Conversation

navidsh
Copy link
Member

@navidsh navidsh commented Mar 18, 2020

What this PR does / why we need it?:

  • Adds support for converting Open Container Initiative annotations added by Appsody into OpenShift equivalent annotation

Does this PR introduce a user-facing change?

  • User guide
  • CHANGELOG.md

Which issue(s) this PR fixes:

Fixes #

leochr
leochr approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@navidsh navidsh merged commit cd13d98 into master Mar 18, 2020
@leochr leochr mentioned this pull request Mar 23, 2020
Closed
@navidsh navidsh deleted the vcs branch May 25, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leochr leochr leochr approved these changes

@arturdzm arturdzm arturdzm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@navidsh @arturdzm @leochr