Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hybrid components throw invariant error in IE11 #220

Closed
sodiumjoe opened this issue May 5, 2016 · 4 comments
Closed

hybrid components throw invariant error in IE11 #220

sodiumjoe opened this issue May 5, 2016 · 4 comments
Assignees
@sodiumjoe
Labels
bug
Milestone
1.0.0

Comments

@sodiumjoe
Copy link
Contributor

No description provided.

@sodiumjoe sodiumjoe self-assigned this May 5, 2016
@sodiumjoe sodiumjoe added the bug label May 5, 2016
@sodiumjoe sodiumjoe added this to the 1.0.0 milestone May 5, 2016
@sodiumjoe
Copy link
Contributor Author

waiting for repro steps

@jondlm
Copy link
Contributor

jondlm commented May 5, 2016

Found one issue with the demo page but I don't think it's related to the core issue being talked about there.

jondlm added a commit that referenced this issue May 5, 2016
@jondlm
Issue #220 - demo page had duplicate properties
d18b551
@sodiumjoe
Copy link
Contributor Author

There's a more general issue with how we're defining our components. Solution is to stick all of our non-standard properties on statics.

sodiumjoe added a commit to sodiumjoe/lucid that referenced this issue May 7, 2016
@sodiumjoe
fixes appnexus#220 refactor createClass and buildHybrid to avoid inva…
d178a20 
…riant error

Change createClass to explicitly pass through the component definition
so buildHybrid can grab the explicit statics instead of inferring them
from the top-level component definition properties. This lets us avoid
accidentally colliding with any React default class properties, which
causes an invariant error.
@sodiumjoe
Copy link
Contributor Author

addressed in #224

@sodiumjoe sodiumjoe mentioned this issue May 9, 2016
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sodiumjoe sodiumjoe

Labels
bug
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@sodiumjoe @jondlm