Charts #232
Charts #232
Conversation
- Improved the color palette page - Updated contrib docs with new _lucidIsPrivate convention - Several new private components that power charts - Cleaned up variables.less - Updated generic tests to handle function props that don't start with `on` - Added new colors for charts - Added new utilities to support charts
| * Classes are appended to root element along with existing classes using | ||
| * the `classnames` library. | ||
| */ | ||
| className: any, |
There was a problem hiding this comment.
we're pretty inconsistent about this, but shouldn't this be string
There was a problem hiding this comment.
Yeah, I flip flopped on this one. I feel like any is better since we're running stuff through classnames which could potentially be useful to a consumer.
There was a problem hiding this comment.
seems like consumer could just run through classnames if they need to generate a string
There was a problem hiding this comment.
Cool beans, I'm fine with that. I'll fix my stuff up.
| @@ -0,0 +1,107 @@ | |||
| // Note: these tests are basically pin tests, given that we're rendering svgs, | |||
There was a problem hiding this comment.
src/components/BarChart/BarChar.spec.jsx
There was a problem hiding this comment.
should be src/components/BarChart/BarChart.spec.jsx
| * @return {array[]} - array of arrays, one for each field | ||
| */ | ||
| export function groupByFields(collection, fields) { | ||
| const fieldsArray = [].concat(fields); |
There was a problem hiding this comment.
Just some sugar to allow me to pass in either a string or an array of strings. I saw @ogupte doing it and I thought it was cool. And I want to be cool
There was a problem hiding this comment.
it's a way to coerce any value into an array
| // Domain | ||
| const range = scale.range(); | ||
| const sign = orient === 'top' || orient === 'left' ? -1 : 1; | ||
| const isH = orient === 'top' || orient === 'bottom'; |
There was a problem hiding this comment.
is isH short for isHorizontal?
There was a problem hiding this comment.
Yep, that's right. I wanted to keep it small since I'm using in lots of small ternaries.
…charts-squashed Conflicts: src/styles/variables.less
PR Checklist
commonat minimum)semver-labelson