Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't render when portal isn't rendered #238

Merged
merged 2 commits into from
May 12, 2016
Merged

don't render when portal isn't rendered #238

merged 2 commits into from
May 12, 2016

Conversation

sodiumjoe
Copy link
Contributor

@sodiumjoe sodiumjoe commented May 11, 2016 •
edited
Loading

PR Checklist

  • Manually tested across supported browsers
    • Chrome
    • Firefox
    • Safari
    • IE11 (Win 7)
    • Edge (Win 10)
  • Unit tests written (common at minimum)
  • PR has one of the semver- labels
  • Two core team engineer approvals

@sodiumjoe sodiumjoe self-assigned this May 11, 2016
@sodiumjoe sodiumjoe merged commit 1457200 into master May 12, 2016
@jondlm jondlm deleted the optimize-flyout branch June 8, 2016 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sodiumjoe sodiumjoe

Labels
semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sodiumjoe @ogupte @jondlm