Branding refresh and VerticalListMenu tweaks #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Recurse | ||
| .ColorPalette-loop(@i - 1); | ||
| } | ||
|
|
||
| .lucid-ColorPalette { | ||
| .ColorPalette { | ||
| padding: 15px; |
There was a problem hiding this comment.
should this be a variable
There was a problem hiding this comment.
Yeah probably, I use it in lots of places. I've been cutting some corners on the demo page :/
- Fix VerticalListMenu usage on the docs page
| export function buildHybridComponent(baseComponent, { | ||
| setStateWithNewProps = true, // if true, new props will update state, else prop has priority over existing state | ||
| replaceEvents = false, // if true, function props replace the existing reducers, else they are invoked *after* state reducer returns | ||
| reducers = _.get(baseComponent, 'definition.statics.reducers', {}), |
There was a problem hiding this comment.
Yup! I wrote a test for it too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildHybridComponentto acceptreducersas an option so I could override the behavior for the demo pagePR Checklist
commonat minimum)semver-labels