default ColumnGroup props.align to 'center' #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add tests around ColumnGroup alignment * fix examples to use defaults
|
turns out the alignment thing was already fixed in #284 I just added the default center alignment to |
sodiumjoe
force-pushed
the
280-DataTable-column-header-alignment
branch
from
ccc7d21
to
fbc9793
Compare
| .find(ScrollTable.Tr).first().shallow() | ||
| .find(ScrollTable.Th).at(1).shallow() | ||
|
|
||
| assert(thWrapper.hasClass('lucid-Table-align-center'), 'must be true'); |
There was a problem hiding this comment.
the useful message should be must have correct className or something like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #280, fixes #290
PR Checklist
commonat minimum)semver-labels[ ] One core team UX approval