Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant events from radiobutton and checkbox #339

Merged
merged 2 commits into from
Jun 13, 2016

Conversation

sodiumjoe
Copy link
Contributor

@sodiumjoe sodiumjoe commented Jun 13, 2016

fixes #338

http://docspot.devnxs.net/projects/lucid/bugfix-338-checkbox-radiobutton/

PR Checklist

  • Manually tested across supported browsers
    • Chrome
    • Firefox
    • Safari
    • IE11 (Win 7)
    • Edge (Win 10)
  • Unit tests written (common at minimum)
  • PR has one of the semver- labels
  • Two core team engineer approvals
  • [ ] One core team UX approval

@jondlm
Copy link
Contributor

jondlm commented Jun 13, 2016

I also tested on all the browsers and it's working as expected now

@jondlm jondlm merged commit 320d052 into master Jun 13, 2016
@jondlm jondlm deleted the bugfix/338-checkbox-radiobutton branch June 13, 2016 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox/RadioButton event handlers fire twice per click
3 participants