Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes onSelect being called despite isDisabled #591

Merged
merged 3 commits into from
Oct 21, 2016
Merged

Fixes onSelect being called despite isDisabled #591

merged 3 commits into from
Oct 21, 2016

Conversation

mute
Copy link
Contributor

@mute mute commented Oct 20, 2016 •
edited
Loading

PR Checklist

  • Manually tested across supported browsers
    • Chrome
    • Firefox
    • Safari
    • IE11 (Win 7)
    • Edge (Win 10)
  • Unit tests written (common at minimum)
  • PR has one of the semver- labels
  • Two core team engineer approvals
  • [ ] One core team UX approval

Fleshes out Tab child component.

Fixes #579

@mute
Fixes onSelect being called despite isDisabled
72d6597 
Fleshes out `Tab` child component.
@mute mute self-assigned this Oct 20, 2016
sodiumjoe
sodiumjoe approved these changes Oct 21, 2016
View reviewed changes
Copy link
Contributor

@sodiumjoe sodiumjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great 👍

@mute mute merged commit b09c924 into master Oct 21, 2016
@mute mute deleted the 579-onSelect-disabled branch October 21, 2016 23:07
@mute mute removed the in progress label Oct 21, 2016
@mute mute mentioned this pull request Oct 24, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jondlm jondlm jondlm approved these changes

@ogupte ogupte ogupte approved these changes

@sodiumjoe sodiumjoe sodiumjoe approved these changes

Assignees

@mute mute

Labels
semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mute @sodiumjoe @ogupte @jondlm