propagate native element refs and add focus methods #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogupte
approved these changes
Oct 21, 2016
jondlm
reviewed
Oct 21, 2016
| @@ -58,10 +58,15 @@ const TextFieldValidated = createClass({ | |||
| return TextField.getDefaultProps(); | |||
| }, | |||
|
|
|||
| focus() { | |||
| this.refs.TextField.focus(); | |||
There was a problem hiding this comment.
Not sure if this is a dumb question, but is it ever possible for a consumer to call this function before render has had a chance to make this property available?
There was a problem hiding this comment.
I don't think so, because the method is on the instance that's the result of the render.
There was a problem hiding this comment.
good question, tho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
commonat minimum)semver-labels[ ] One core team UX approval