Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant propTypes from TextFieldValidated #601

Merged
merged 3 commits into from
Oct 27, 2016
Merged

remove redundant propTypes from TextFieldValidated #601

merged 3 commits into from
Oct 27, 2016

Conversation

sodiumjoe
Copy link
Contributor

@sodiumjoe sodiumjoe commented Oct 24, 2016 •
edited
Loading

PR Checklist

  • Manually tested across supported browsers
    • Chrome
    • Firefox
    • Safari
    • IE11 (Win 7)
    • Edge (Win 10)
  • Unit tests written (common at minimum)
  • PR has one of the semver- labels
  • Two core team engineer approvals
  • [ ] One core team UX approval

@sodiumjoe sodiumjoe self-assigned this Oct 24, 2016
@jhsu
Copy link
Collaborator

jhsu commented Oct 27, 2016 •
edited
Loading

currently causes a bug where value and all the event handlers get omitted

@sodiumjoe sodiumjoe merged commit 25f8987 into master Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogupte ogupte ogupte approved these changes

@mute mute mute approved these changes

Assignees

@sodiumjoe sodiumjoe

Labels
semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sodiumjoe @jhsu @mute @ogupte