Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searchfield export #623

Merged
merged 3 commits into from
Nov 14, 2016
Merged

Searchfield export #623

merged 3 commits into from
Nov 14, 2016

Conversation

sodiumjoe
Copy link
Contributor

@sodiumjoe sodiumjoe commented Nov 11, 2016

PR Checklist

  • Manually tested across supported browsers
    • Chrome
    • Firefox
    • Safari
    • IE11 (Win 7)
    • Edge (Win 10)
  • Unit tests written (common at minimum)
  • PR has one of the semver- labels
  • Two core team engineer approvals
  • One core team UX approval

@codecov-io
Copy link

Current coverage is 91.11% (diff: 100%)

Merging #623 into master will not change coverage

@@             master       #623   diff @@
==========================================
  Files           154        154          
  Lines          2612       2612          
  Methods         261        261          
  Messages          0          0          
  Branches        718        718          
==========================================
  Hits           2380       2380          
  Misses          221        221          
  Partials         11         11          

Powered by Codecov. Last update 0c83009...4f813bb

Copy link
Contributor

@mute mute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙆‍♂️

@ogupte
Copy link
Contributor

ogupte commented Nov 12, 2016

fixes #614

@sodiumjoe sodiumjoe merged commit 00206d5 into master Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants