Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set minWidth on expanded Sidebar in case it renders offscreen. #701

Merged
merged 5 commits into from
Feb 2, 2017
Merged

Set minWidth on expanded Sidebar in case it renders offscreen. #701

merged 5 commits into from
Feb 2, 2017

Conversation

ogupte
Copy link
Contributor

@ogupte ogupte commented Feb 1, 2017 •
edited
Loading

Fixes #611

PR Checklist

  • Manually tested across supported browsers
    • Chrome
    • Firefox
    • Safari
    • IE11 (Win 7)
    • Edge (Win 10)
  • Unit tests written (common at minimum)
  • PR has one of the semver- labels
  • Two core team engineer approvals
  • One core team UX approval

@ogupte ogupte self-assigned this Feb 1, 2017
mute
mute approved these changes Feb 1, 2017
View reviewed changes
Copy link
Contributor

@mute mute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙆‍♂️

@codecov-io
Copy link

codecov-io commented Feb 1, 2017 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@30b2a19). Click here to learn what that means.

@@            Coverage Diff            @@
##             master     #701   +/-   ##
=========================================
  Coverage          ?   91.29%           
=========================================
  Files             ?      157           
  Lines             ?     2666           
  Branches          ?      736           
=========================================
  Hits              ?     2434           
  Misses            ?      221           
  Partials          ?       11
Impacted Files Coverage Δ
src/components/Sidebar/Sidebar.jsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b2a19...be7a3d5. Read the comment docs.

@sodiumjoe sodiumjoe merged commit cf087e1 into master Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jondlm jondlm jondlm approved these changes

@sodiumjoe sodiumjoe sodiumjoe approved these changes

@mute mute mute approved these changes

Assignees

@ogupte ogupte

Labels
semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ogupte @codecov-io @mute @sodiumjoe @jondlm