Added new OutwardArrowsIcon #725
Conversation
| @@ -49,7 +49,6 @@ import CrossIcon from './components/Icon/CrossIcon/CrossIcon'; | |||
| import DangerIcon from './components/Icon/DangerIcon/DangerIcon'; | |||
| import DangerLightIcon from './components/Icon/DangerLightIcon/DangerLightIcon'; | |||
| import DataTable from './components/DataTable/DataTable'; | |||
| import EmptyStateWrapper from './components/EmptyStateWrapper/EmptyStateWrapper'; | |||
There was a problem hiding this comment.
Just sorting alphabetically
|
|
||
| const cx = lucidClassNames.bind('&-OutwardArrowsIcon'); | ||
|
|
||
| const paths = { |
There was a problem hiding this comment.
I created a single icon that supports all three rotations
There was a problem hiding this comment.
will there never be a use case for diagonal the other way?
There was a problem hiding this comment.
I don't think so, it could be diagonal-inverted 🚎
But yeah, I don't think so.
There was a problem hiding this comment.
should be oneOf(['horizontal', 'vertical', '/', '\'])
|
|
||
| const cx = lucidClassNames.bind('&-OutwardArrowsIcon'); | ||
|
|
||
| const paths = { |
There was a problem hiding this comment.
will there never be a use case for diagonal the other way?
Codecov Report
@@ Coverage Diff @@
## master #725 +/- ##
==========================================
+ Coverage 91.65% 91.67% +0.02%
==========================================
Files 161 162 +1
Lines 2803 2810 +7
Branches 791 791
==========================================
+ Hits 2569 2576 +7
Misses 223 223
Partials 11 11
Continue to review full report at Codecov.
|
Fixes #708
http://docspot.devnxs.net/projects/lucid/708-icons/#/components/OutwardArrowsIcon
PR Checklist
commonat minimum)semver-labels