Chore/update storybook etc #963
Conversation
- Regenerate snapshots due to minor changes to enzyme's shallow render behavior
ghost
added
| }); | ||
| } | ||
| const portalElement = window.document.createElement('div'); | ||
| window.parent.document.body.appendChild(portalElement); |
There was a problem hiding this comment.
storybook puts content in an iframe, so the statically positioned toggle would be pinned to the iframe. We shouldn't run into any cross-origin issues.
| showAddonPanel: !urlState.addons, | ||
| }); | ||
| } | ||
| export const withPanelToggles = makeDecorator({ |
There was a problem hiding this comment.
Using storybook's decorator functionality since we only want the toggle visible on "example" pages and not our "article" pages.
| // For some reason this doesn't pickup our .babelrc even though it's supposed to | ||
| return babelCore.transform(codeMap[specifierType], { presets: ['es2015'] }) | ||
| .code; | ||
| return babelCore.transform(codeMap[specifierType]).code; |
There was a problem hiding this comment.
babel presets were removed. Seems to pick up babelrc fine now.
| @@ -284,7 +284,7 @@ describe('Autocomplete', () => { | |||
| }); | |||
|
|
|||
| afterEach(() => { | |||
| if (wrapper) { | |||
| if (wrapper && wrapper.exists()) { | |||
There was a problem hiding this comment.
fixes some flaky tests where we were trying to unmount components already unmounted.
| @@ -7,7 +7,9 @@ exports[`Collapsible [common] example testing should match snapshot(s) for 1.tog | |||
| "height": 0, | |||
| } | |||
| } | |||
| /> | |||
| > | |||
There was a problem hiding this comment.
enzyme shallow no longer uses a self closing tags, and now includes the immediate child's text/node
| render() { | ||
| const urlState = this.props.api.getUrlState(); | ||
|
|
||
| if (urlState.full || !urlState.addons) { |
There was a problem hiding this comment.
urlState.addons intended use is to control the visibility of the panel sidebar. Using that here creates a bug where if the user hides the sidebar and later reloads the url we don't show the toggle component. Example: https://docspot.adnxs.net/projects/lucid/latest/?selectedKind=DropMenu&selectedStory=stateless&full=0&addons=0&stories=1&panelRight=1&addonPanel=lucid-docs-panel-props
This code is effectively replaced by using the new panelToggle decorator.
|
There is a regression in this PR where we no longer remember the visibility or selection state of the side panel when navigating between stories. We need to set options on each individual story so that the Article stories hide the sidebar, and Example stories show the sidebar. Storybook does all of this while initializing, and I can't see a way to merge these overrides with user's current selections. I tried a couple of different approaches, but couldn't get it working the way I wanted it to. The current approach is at least consistent where example pages show the sidebar on the right and article pages hide the sidebar. |
|
Seems like a minor enough issue to me. I'd much rather have all these upgrades! |
package.json
Outdated
| @@ -2,6 +2,9 @@ | |||
| "name": "lucid-ui", | |||
| "version": "2.36.5", | |||
| "description": "A UI component library from AppNexus.", | |||
| "engines": { | |||
| "node": ">=8.12.0" | |||
There was a problem hiding this comment.
I think I need to remove this since it throws an error during npm install if the node engine doesn't match. Is there a better way to flag that development must be done >=8, but it doesn't matter for consumers of the library?
There was a problem hiding this comment.
Good question. I've seen folks use a little bash script to check the version of node instead of engines but it's certainly not as clean. As far as I can tell there isn't a clear hook we could use to only run a script when running yarn install from within lucid (i.e. you're a developer working on lucid). Maybe we should just skip this problem for now and instead document it in the README?
…do not get an install error.
Codecov Report
@@ Coverage Diff @@
## master #963 +/- ##
==========================================
- Coverage 90.06% 90.04% -0.03%
==========================================
Files 183 183
Lines 3453 3456 +3
Branches 1110 1112 +2
==========================================
+ Hits 3110 3112 +2
+ Misses 322 321 -1
- Partials 21 23 +2
|
ghost
merged commit 
PR Checklist
commonat minimum)semver-labels