Figures bug fixes #213
Merged
Figures bug fixes #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johnbaldwin
commented
May 7, 2020
•
johnbaldwin
commented
- Addresses progress data pipeline errors in LearnerCourseDetails serializer
- Failed call to figures.metrics.get_course_average_progress_for_time_period #217
- Added testing for LearnerCourseGradeMetricsManager
- Updates LearnerCourseDetailsSerializer.get_prgress_data check if there is not a record to process
- Adds serializer testing for the above
- Fixes Ginkgo migration for a Django 1.8 -> 1.11 incompatibility
Django post 1.8 introduced a site model change that is not backward compatible, so we have a conditional dependency depending on the Django version
Test fails because a datetime based query returns empty results when freezegun is enabled in Ginkgo. Skipping test if environment is Ginkgo until we can make time to investigate and fix
If there aren't any matching LearnerCourseGradeMetrics records matching the filtering criteria then an exception is raised and trapped, triggering an error log. This does not change the behvior of the method. What is does is reduce logging noise to the log files and also does not create a `PipelineError` table log enty, saving database space
OmarIthawi
reviewed
May 7, 2020
There was a problem hiding this comment.
Thanks @johnbaldwin. I need to unassign myself from this to focus on Multi-Tenant Emails.
|
@johnbaldwin I'll review this one today. |
melvinsoft
approved these changes
May 8, 2020
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
==========================================
- Coverage 91.31% 91.12% -0.19%
==========================================
Files 37 37
Lines 1876 1882 +6
==========================================
+ Hits 1713 1715 +2
- Misses 163 167 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.