Ginkgo backward compatibility fix for Django Filters #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Django Filters < 1.0.0 requires 'lookup_type' instead of 'lookup_expr' for CharField expression. This commit adds a `char_filter` method to `figures.filters` to address this compatibility issue. The `char_filter` function was copied and adapted from the `figures/filteres.py` update from the JJuniper upgrade PR: #264 IMPORTANT: We did not update `tests/test_filters.py` at this time in order to save development time. We may revisit this decision
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
- Coverage 91.95% 91.89% -0.07%
==========================================
Files 41 41
Lines 2150 2158 +8
==========================================
+ Hits 1977 1983 +6
- Misses 173 175 +2
Continue to review full report at Codecov.
|
OmarIthawi
approved these changes
Oct 12, 2020
|
Thanks @OmarIthawi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django Filters < 1.0.0 requires 'lookup_type' instead of 'lookup_expr'
for CharField expression. This commit adds a
char_filtermethod tofigures.filtersto address this compatibility issue. Thechar_filterfunction was copied and adapted from the
figures/filteres.pyupdatefrom the JJuniper upgrade PR:
#264
IMPORTANT: We did not update
tests/test_filters.pyat this time inorder to save development time. We may revisit this decision
After this is merged to master, I will