Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Ginkgo (Django Filter 0.11.0) Backward compatibility issue #269

Merged
merged 2 commits into from
Oct 16, 2020

Commits on Oct 15, 2020

  1. Fixed Ginkgo (Django Filter 0.11.0) Backward compatibility issue

    Added a shim for Django Filter 0.11.0 call to MethodFilter
    
    This addresses a compatibility issue where custom filter methods for Django Filter 1.x onward uses the following method signature:
    
    `(self, queryset, name, value)`
    
    Whereas Django Filter 0.11.0 uses the following method signature:
    
    `(self, queryset, value)`
    
    Primarily, we need to implement the shim because positional arguements instead of keyword arguments are used.
    johnbaldwin committed Oct 15, 2020
    Configuration menu
    Copy the full SHA
    36fd9d1 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2020

  1. Configuration menu
    Copy the full SHA
    7f204b9 View commit details
    Browse the repository at this point in the history