Change default Rake task namespace to rake (#1202)

appsignal · Jul 24, 2024 · 7673b13 · 7673b13
1 parent 1b1880a
commit 7673b13
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/.changesets/rake-task-namespace.md b/.changesets/rake-task-namespace.md
@@ -0,0 +1,6 @@
+---
+bump: major
+type: change
+---
+
+Change the default Rake task namespace to "rake". Previously, Rake tasks were reported in the "background" namespace.
diff --git a/lib/appsignal/integrations/rake.rb b/lib/appsignal/integrations/rake.rb
@@ -25,6 +25,7 @@ def execute(*args)
           params, _ = args
           params = params.to_hash if params.respond_to?(:to_hash)
           transaction.set_params_if_nil(params)
+          transaction.set_params_if_nil(params)
           transaction.set_action(name)
           transaction.complete
         end
@@ -33,7 +34,7 @@ def execute(*args)
       private
 
       def _appsignal_create_transaction
-        Appsignal::Transaction.create(Appsignal::Transaction::BACKGROUND_JOB)
+        Appsignal::Transaction.create("rake")
       end
     end
 

diff --git a/spec/lib/appsignal/hooks/rake_spec.rb b/spec/lib/appsignal/hooks/rake_spec.rb
@@ -55,7 +55,7 @@ def perform
 
           transaction = last_transaction
           expect(transaction).to have_id
-          expect(transaction).to have_namespace(Appsignal::Transaction::BACKGROUND_JOB)
+          expect(transaction).to have_namespace("rake")
           expect(transaction).to have_action("task:name")
           expect(transaction).to_not have_error
           expect(transaction).to include_params("foo" => "bar")
@@ -88,7 +88,7 @@ def perform
 
         transaction = last_transaction
         expect(transaction).to have_id
-        expect(transaction).to have_namespace(Appsignal::Transaction::BACKGROUND_JOB)
+        expect(transaction).to have_namespace("rake")
         expect(transaction).to have_action("task:name")
         expect(transaction).to have_error("ExampleException", "error message")
         expect(transaction).to include_params("foo" => "bar")