Fix Padrino require error

When Padrino is loaded it will raise an error about `Rack::Server` not being found. That's because the constant has been renamed to `Rackup::Server` in newer versions of Rack and Rackup. The latest version of Padrino is not updated for this yet, so catch the error if it occurs. This makes our detection a bit less accurate, but at least it won't crash the installer.
appsignal · Jul 31, 2024 · dfe2370 · dfe2370
1 parent 98fae7e
commit dfe2370
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.changesets/fix-error-on-padrino-require.md b/.changesets/fix-error-on-padrino-require.md
@@ -0,0 +1,6 @@
+---
+bump: patch
+type: fix
+---
+
+Fix an error on the Padrino require in the installer CLI. The latest Padrino version will crash the installer on load. Ignore the error when it fails to load.
diff --git a/lib/appsignal/cli/install.rb b/lib/appsignal/cli/install.rb
@@ -281,7 +281,7 @@ def installed_frameworks
         def framework_available?(framework_file)
           require framework_file
           true
-        rescue LoadError
+        rescue LoadError, NameError
           false
         end