Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve installer flow #315

Closed
6 tasks done
Tracked by #667
tombruijn opened this issue Jun 14, 2017 · 1 comment · Fixed by #1246
Closed
6 tasks done
Tracked by #667

Improve installer flow #315

tombruijn opened this issue Jun 14, 2017 · 1 comment · Fixed by #1246
Assignees
@tombruijn
Labels
enhancement

Comments

@tombruijn
Copy link
Member

tombruijn commented Jun 14, 2017 •
edited
Loading

Related issues
@tombruijn tombruijn added this to the Ruby gem 2.4 milestone Aug 11, 2017
@tombruijn tombruijn changed the title Improve installer flow ⌨️ Improve installer flow Oct 27, 2017
tombruijn added a commit that referenced this issue May 3, 2018
@tombruijn
Fix install test for unknown-type apps
b61280a 
We don't print any config in this scenario.
We should, see #315
@tombruijn tombruijn changed the title ⌨️ Improve installer flow Improve installer flow May 30, 2018
@tombruijn tombruijn removed this from the The next minor Ruby gem version milestone Jan 7, 2019
@tombruijn
Copy link
Member Author

https://app.intercom.io/a/apps/yzor8gyw/inbox/inbox/540709/conversations/23457065340

@tombruijn tombruijn mentioned this issue Oct 2, 2019
Merged
tombruijn added a commit that referenced this issue Oct 2, 2019
@tombruijn @mbirman
Handle missing application.rb for Rails installer
157e7b2 
When an app is detected as a Rails app by the presence of the `rails`
gem we load the `config/application.rb` file, assuming it exists. Catch
the scenario where it doesn't.

It doesn't error anymore, but doesn't show the desired output perhaps,
it only ends the installer without prompting the user for a custom app
name. This should be picked up as part of #315.

Co-authored-by: Mark <birmanmark@gmail.com>
@jeffkreeftmeijer jeffkreeftmeijer closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2024
@tombruijn tombruijn reopened this Apr 19, 2024
@tombruijn tombruijn mentioned this issue Jul 23, 2024
Closed
82 tasks
tombruijn added a commit that referenced this issue Jul 31, 2024
@tombruijn
Install gem when no known framework found
aed184c 
When no supported framework is installed, the installer would exit. It
would try to send the demo data, but this would always fail because
there is no valid AppSignal config chosen.

Change the installer that it will configure AppSignal when no supported
framework is found, and link to the docs for a list of other libraries
we integrate with. Some manual setup is required but we don't known
which library docs to link to.

Update the installer output to always point people back to installation
instructions in the browser.

Part of #315
@tombruijn tombruijn mentioned this issue Jul 31, 2024
Merged
tombruijn added a commit that referenced this issue Jul 31, 2024
@tombruijn
Install gem when no known framework found
b7fe79d 
When no supported framework is installed, the installer would exit. It
would try to send the demo data, but this would always fail because
there is no valid AppSignal config chosen.

Change the installer that it will configure AppSignal when no supported
framework is found, and link to the docs for a list of other libraries
we integrate with. Some manual setup is required but we don't known
which library docs to link to.

Update the installer output to always point people back to installation
instructions in the browser.

Part of #315
tombruijn added a commit that referenced this issue Jul 31, 2024
@tombruijn
Install gem when no known framework found
6f5ce97 
When no supported framework is installed, the installer would exit. It
would try to send the demo data, but this would always fail because
there is no valid AppSignal config chosen.

Change the installer that it will configure AppSignal when no supported
framework is found, and link to the docs for a list of other libraries
we integrate with. Some manual setup is required but we don't known
which library docs to link to.

Update the installer output to always point people back to installation
instructions in the browser.

Part of #315
tombruijn added a commit that referenced this issue Jul 31, 2024
@tombruijn
Install gem when no known framework found
0fc2253 
When no supported framework is installed, the installer would exit. It
would try to send the demo data, but this would always fail because
there is no valid AppSignal config chosen.

Change the installer that it will configure AppSignal when no supported
framework is found, and link to the docs for a list of other libraries
we integrate with. Some manual setup is required but we don't known
which library docs to link to.

Update the installer output to always point people back to installation
instructions in the browser.

Part of #315
tombruijn added a commit that referenced this issue Jul 31, 2024
@tombruijn
Install gem when no known framework found
a9c546f 
When no supported framework is installed, the installer would exit. It
would try to send the demo data, but this would always fail because
there is no valid AppSignal config chosen.

Change the installer that it will configure AppSignal when no supported
framework is found, and link to the docs for a list of other libraries
we integrate with. Some manual setup is required but we don't known
which library docs to link to.

Update the installer output to always point people back to installation
instructions in the browser.

Part of #315
@tombruijn tombruijn mentioned this issue Aug 16, 2024
Merged
@tombruijn tombruijn self-assigned this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tombruijn tombruijn

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tiny installer improvements appsignal/appsignal-ruby
2 participants
@jeffkreeftmeijer @tombruijn