Allow tags to contain boolean values #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our pipeline support boolean values in tags. Let's accept those values.
tombruijn
added a commit
that referenced
this pull request
Jul 9, 2024
Refactor the Shoryuken integration not to use the `monitor_transaction` helper. A helper we want to deprecate. The implementation is mostly the same, except how we set the attributes. I have changed it to store them as tags. Previously we set the attributes as "sample data metadata". This is another way to set metadata/tags in the transaction API. All three data types end up in the "overview" tag box, so it doesn't really matter how we set the values. The only thing is that the sample metadata seems to support more tag value types. Which I changed in PR #1169 by accepting boolean values too. For reference, here's a single and matched message's attributes Shoryuken can receive. ```ruby # Single {"queue"=>"default", "SenderId"=>"AIDAIT2UOQQY3AUEKVGXU", "SentTimestamp"=>"1720542601233", "ApproximateReceiveCount"=>"1", "ApproximateFirstReceiveTimestamp"=>"1720542601319", "message_id"=>"9b40dbd8-5c26-40ea-8ded-6d68428072fb"} # Batched {"queue"=>"batched", "SenderId"=>"AIDAIT2UOQQY3AUEKVGXU", "SentTimestamp"=>"1720542649820", "ApproximateReceiveCount"=>"1", "ApproximateFirstReceiveTimestamp"=>"1720542649833", "batch"=>true} ```
tombruijn
added a commit
that referenced
this pull request
Jul 9, 2024
Refactor the Shoryuken integration not to use the `monitor_transaction` helper. A helper we want to deprecate. The implementation is mostly the same, except how we set the attributes. I have changed it to store them as tags. Previously we set the attributes as "sample data metadata". This is another way to set metadata/tags in the transaction API. All three data types end up in the "overview" tag box, so it doesn't really matter how we set the values. The only thing is that the sample metadata seems to support more value types than tags. I changed this in PR #1169 by accepting boolean values in tags. For reference, here's a single and matched message's attributes Shoryuken can receive. ```ruby # Single {"queue"=>"default", "SenderId"=>"AIDAIT2UOQQY3AUEKVGXU", "SentTimestamp"=>"1720542601233", "ApproximateReceiveCount"=>"1", "ApproximateFirstReceiveTimestamp"=>"1720542601319", "message_id"=>"9b40dbd8-5c26-40ea-8ded-6d68428072fb"} # Batched {"queue"=>"batched", "SenderId"=>"AIDAIT2UOQQY3AUEKVGXU", "SentTimestamp"=>"1720542649820", "ApproximateReceiveCount"=>"1", "ApproximateFirstReceiveTimestamp"=>"1720542649833", "batch"=>true} ```
unflxw
approved these changes
Jul 10, 2024
|
For reviewing context: this was implemented as part of work on #1170. |
tombruijn
added a commit
that referenced
this pull request
Jul 10, 2024
Refactor the Shoryuken integration not to use the `monitor_transaction` helper. A helper we want to deprecate. The implementation is mostly the same, except how we set the attributes. I have changed it to store them as tags. Previously we set the attributes as "sample data metadata". This is another way to set metadata/tags in the transaction API. All three data types end up in the "overview" tag box, so it doesn't really matter how we set the values. The only thing is that the sample metadata seems to support more value types than tags. I changed this in PR #1169 by accepting boolean values in tags. For reference, here's a single and matched message's attributes Shoryuken can receive. ```ruby # Single {"queue"=>"default", "SenderId"=>"AIDAIT2UOQQY3AUEKVGXU", "SentTimestamp"=>"1720542601233", "ApproximateReceiveCount"=>"1", "ApproximateFirstReceiveTimestamp"=>"1720542601319", "message_id"=>"9b40dbd8-5c26-40ea-8ded-6d68428072fb"} # Batched {"queue"=>"batched", "SenderId"=>"AIDAIT2UOQQY3AUEKVGXU", "SentTimestamp"=>"1720542649820", "ApproximateReceiveCount"=>"1", "ApproximateFirstReceiveTimestamp"=>"1720542649833", "batch"=>true} ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our pipeline support boolean values in tags. Let's accept those values.
To do
Screenshots