Refactor Delayed::Job integration to not use monitor_transaction #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DelayedJobPlugin was defined in the integrations directory, but used the Hooks module namespace. Update the namespace so it matches its location. No redirect needed because it's a private API no one should be accessing. Split the test file so it tests what's in the related file.
Refactor the Delayed::Job integration not to use the `monitor_transaction` helper. A helper we want to deprecate. The implementation is mostly the same, except how we set the attributes. I have changed it to store them as tags. Previously we set the attributes as "sample data metadata". This is another way to set metadata/tags in the transaction API. All three data types end up in the "overview" tag box, so it doesn't really matter how we set the values. [skip changeset] because it's an internal refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Delayed::Job plugin to integrations namespace
The DelayedJobPlugin was defined in the integrations directory, but used the Hooks module namespace. Update the namespace so it matches its location. No redirect needed because it's a private API no one should be accessing.
Split the test file so it tests what's in the related file.
Do not use monitor_transaction for Delayed::Job
Refactor the Delayed::Job integration not to use the
monitor_transactionhelper. A helper we want to deprecate.The implementation is mostly the same, except how we set the attributes. I have changed it to store them as tags. Previously we set the attributes as "sample data metadata". This is another way to set metadata/tags in the transaction API. All three data types end up in the "overview" tag box, so it doesn't really matter how we set the values.
[skip changeset] because it's an internal refactor.