Deprecate set_http_or_background_queue_start
#1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate the `Transaction#set_http_or_background_queue_start` method so that the transaction doesn't need to know about any 'request' set on the transaction. The instrumentations themselves can set the queue start using the `Transaction#set_queue_start` method. Move the logic for conversion of the queue start time from request headers to a utils class so it can be accessed by the instrumentations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the
Transaction#set_http_or_background_queue_startmethod so that the transaction doesn't need to know about any 'request' set on the transaction. The instrumentations themselves can set the queue start using theTransaction#set_queue_startmethod.Move the logic for conversion of the queue start time from request headers to a utils class so it can be accessed by the instrumentations.