Ignore calls to start AppSignal twice #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When AppSignal has started, ignore any calls to start it multiple times. If applications change the config after start, it should not start AppSignal again. This type of behavior can cause AppSignal boot loops as two configurations fight to be active.
For anyone who finds this private method, ignore any config changes on `Appsignal._config =` when AppSignal has already started. This way Ruby applications in memory can't claim AppSignal is using one config when inspecting `Appsignal.config`, while it has started with another config.
unflxw
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore calls to start AppSignal twice
When AppSignal has started, ignore any calls to start it multiple times. If applications change the config after start, it should not start AppSignal again. This type of behavior can cause AppSignal boot loops as two configurations fight to be active.
Ignore config customization when started
For anyone who finds this private method, ignore any config changes on
Appsignal._config =when AppSignal has already started.This way Ruby applications in memory can't claim AppSignal is using one config when inspecting
Appsignal.config, while it has started with another config.