Include loader and DSL source in diagnose report #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show all sources for config in the diagnose report. I didn't add this in the PRs that added the loaders and DSL config, because no part of the diagnose command would load code that can modify these sources. Now I'm working on loading a Rails app in the diagnose command, so it's good to include these sources for when we also want to include the config from the Rails app.
tombruijn
force-pushed
the
diagnose-loader-dsl-sources
branch
from
4e49f8d
to
b32253d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show all sources for config in the diagnose report. I didn't add this in the PRs that added the loaders and DSL config, because no part of the diagnose command would load code that can modify these sources. Now I'm working on loading a Rails app in the diagnose command, so it's good to include these sources for when we also want to include the config from the Rails app.
[skip review]