Use report_error in Rails error subscriber #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Rails error subscriber had already some kind of duplicate transaction behavior, when we didn't support multiple errors. Remove the transaction duplication logic and use `Appsignal.report_error` instead, to report the error. This will duplicate the transaction metadata more accurately when the transaction is closed, rather than whenever the error is reported. It will also duplicate all the sample data, not just tags. If a "context" is given to `Rails.error.handle`, it will overwrite the data on the transaction with the given data. This is mostly useful for errors outside of an instrumented context, when a new transaction is created by `Appsignal.report_error`, and shouldn't be necessary for most other cases. [skip changeset]
tombruijn
force-pushed
the
rails-error-subscribe-report-error
branch
from
660d560
to
6e83ae6
Compare
luismiramirez
approved these changes
Aug 12, 2024
ryansch
added a commit
to detaso/appsignal-ruby
that referenced
this pull request
Aug 14, 2024
* upstream/develop: (33 commits) Bump agent to version 0.35.21 (appsignal#1244) Remove heartbeat aliases and warnings Publish package v3.13.0 Amend `@since` version number Add Rails 7.2 to CI build (appsignal#1242) Bump Ruby versions in the CI (appsignal#1241) Use new property names Remove initial config from Config class Add new build_config spec helper Update Capistrano integrations config Validate config right before start Do not auto validate config on initialize Remove app env key logic from Config initializer Remove custom config file config parameter Remove Appsignal.config= writer Record load and other errors on Rails app load Mark app as Rails app in diagnose report Use report_error in Rails error subscriber (appsignal#1240) Do not report HTTP gem errors (appsignal#1239) Load Rails config in diagnose CLI ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rails error subscriber had already some kind of duplicate transaction behavior, when we didn't support multiple errors.
Remove the transaction duplication logic and use
Appsignal.report_errorinstead, to report the error. This will duplicate the transaction metadata more accurately when the transaction is closed, rather than whenever the error is reported. It will also duplicate all the sample data, not just tags.If a "context" is given to
Rails.error.handle, it will overwrite the data on the transaction with the given data. This is mostly useful for errors outside of an instrumented context, when a new transaction is created byAppsignal.report_error, and shouldn't be necessary for most other cases.[skip changeset]