Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Microsoft Windows crashes #313

Merged
merged 7 commits into from
Jun 22, 2017
Merged

Fix Microsoft Windows crashes #313

merged 7 commits into from
Jun 22, 2017

Commits on Jun 16, 2017

  1. Fix system tmp dir config on Microsoft Windows 

    This is not to fix Microsoft Windows support entirely, but just to allow
users to install AppSignal without errors on the OS. This does not
guarantee AppSignal working in its entirety on Microsoft's OS.

This change uses a different method to find the tmp dir for Windows
while keeping the original logic for *NIX and macOS. Because the logic
is a bit more dynamic now for the system's tmp dir I moved it to a
method that's stubbed for most specs, except the ones that test the
actual implementation of the method.
    @tombruijn
    tombruijn committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    9f11f9f View commit details
    Browse the repository at this point in the history

  2. Fix diagnose task when extension is not loaded 

    When the extension is not loaded running the diagnose task will error
out when parsing the agent report when requested from the extension.
This change checks beforehand if the extension is loaded or not.
    @tombruijn
    tombruijn committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    1532f9b View commit details
    Browse the repository at this point in the history

  3. Update installer output for Windows 

    Print done notice even when we don't detect the framework. Then also
send a demo sample. Hopefully the red "Warning" will attract people's
attention that even thought the installation has been completed we still
can't detect the framework.

Printing the done notice also prints the warning when a user is
installing AppSignal on Windows.
    @tombruijn
    tombruijn committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    5938085 View commit details
    Browse the repository at this point in the history

  4. Add warning to diagnose when on Microsoft Windows

    @tombruijn
    tombruijn committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    1d65f8f View commit details
    Browse the repository at this point in the history

  5. Fix broken user name calls on Microsoft Windows 

    Don't save the username on Microsoft Windows, but also don't error the
program. The `Etc.getpwuid(uid)` returns `nil` on Windows.
    @tombruijn
    tombruijn committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    f7456e7 View commit details
    Browse the repository at this point in the history

  6. Fix hanging installer & diagnose on Windows 

    Write output immediately to STDOUT on Microsoft Windows.
Without `$stdout.sync = true` the output would be saved until the end of
the program and then flushed to STDOUT.

When we print the output immediately we don't get the illusion of a
hanging installer and diagnose task when we ask for user input. Because
the user input prompt hasn't been flushed to STDOUT the user doesn't see
what's expected of them to do. This change fixes that.
    @tombruijn
    tombruijn committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    eedefdb View commit details
    Browse the repository at this point in the history

  7. Fix "Press any key" on Microsoft Windows 

    `getch` throws a `Errno::EBADF: Bad file descriptor` error on Microsoft
Windows. I am unable to fix that. Using `getc` creates the same behavior
and also works on Microsoft Windows.

This fixes the "Press any key" prompts on Microsoft's OS, fixing the
installer prompts.
    @tombruijn
    tombruijn committed Jun 16, 2017
    Configuration menu
    Copy the full SHA
    8a82c09 View commit details
    Browse the repository at this point in the history