Extract backwards compatibility logic to a method #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombruijn
force-pushed
the
refactor/config-load_from_disk
branch
from
eba5729
to
0bd362f
Compare
Closed
|
Code looks good, but I think using "deprecated" instead of "old" to refer to the keys would be just a little more descriptive. |
This keeps the backwards compatibility logic in one place, rather than part of `Appsignal::Config#load_from_disk`. Also print a warning message when an old key name is found and delete it from the config hash, so it can't be accidentally used by something else, internally or by the user. This allows us to actually remove these old keys, because now they're silently supported. Suddenly removing support for these keys could introduce a (small) new wave of support issues.
tombruijn
force-pushed
the
refactor/config-load_from_disk
branch
from
0bd362f
to
7529bf5
Compare
|
@jeffkreeftmeijer updated the constant name. I'm thinking of merging this, as it's quite a small change aimed at printing deprecation warnings. Did you have any other comments in your review? |
thijsc
approved these changes
Oct 31, 2017
jeffkreeftmeijer
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the backwards compatibility logic in one place, rather than
part of
Appsignal::Config#load_from_disk.Also print a warning message when an old key name is found and delete it
from the config hash, so it can't be accidentally used by something
else, internally or by the user.
This allows us to actually remove these old keys, because now they're
silently supported. Suddenly removing support for these keys could
introduce a (small) new wave of support issues.