Use Dir.pwd instead of ENV['PWD'] in Capistrano integration #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of mocking the `Dir.pwd` method, switch the current directory to what the test expects it to be. This doesn't interfere with our internal test system.
A changeset is required to ship the change. https://github.com/appsignal/mono/#changeset [ci skip]
|
Thanks @tombruijn, is there anything else that I need to do to help? |
|
@tomascco No I think we're good. I was just waiting for the build to be green :) |
|
@tomascco I've published the fix in version 3.0.27 of our Ruby gem. |
|
Many thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using a pretty different setup for my Deploy with Capistrano, which includes deploying from a dev container in rootless podman, using the Ruby on Whales guide, with some changes.
I don't know exactly why it happens, but when deploying
ENV["PWD"]returnsnil. I tinkered a little and it seems thatDir.pwdis more reliable.