Accept URI objects for HTTP integration #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HTTP::Client#request allows URI objects and objects responding to #to_s and/or #to_str as a request uri. The HTTP.rb integration doesn't take this into account and is causing failures on the client side when passing an URI object to the request method.
tombruijn
approved these changes
Nov 21, 2022
|
I've published the fix in Ruby gem 3.2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HTTP::Client#requestallows URI objects and objects responding to#to_sand/or#to_stras a request uri.The HTTP.rb integration doesn't take this into account and is causing failures on the client side when passing an URI object to the request method.
I missed this during the original implementation and it might cause issues for people passing an
URIobject to the HTTP gem. Also see; https://github.com/httprb/http/blob/13ce3c2710bc27b467dda68f908149a2f69643cc/lib/http/request.rb#L82I'm looking for feedback in regard to the added test cases. I'm not sure if these add any extra value, but I'd love to hear more about your thoughts @tombruijn.