Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add apparmor profiles for ubuntu 24.04 or higher distros #2262

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

JasonYangShadow
Copy link
Member

Description of the Pull Request (PR):

add apparmor profiles for ubuntu 24.04 or higher distros

This fixes or addresses the following GitHub issues:

Before submitting a PR, make sure you have done the following:

.github/workflows/ci.yml Outdated Show resolved Hide resolved
INSTALL.md Outdated Show resolved Hide resolved
dist/debian/apparmor-placeholder Outdated Show resolved Hide resolved
dist/debian/apparmor-userns Outdated Show resolved Hide resolved
dist/debian/rules Outdated Show resolved Hide resolved
scripts/ci-deb-build-test Outdated Show resolved Hide resolved
scripts/ci-deb-build-test Outdated Show resolved Hide resolved
scripts/ci-deb-build-test Show resolved Hide resolved
scripts/ci-deb-build-test Outdated Show resolved Hide resolved
@JasonYangShadow JasonYangShadow force-pushed the issue/2027 branch 4 times, most recently from 5b40970 to 341a4a8 Compare June 18, 2024 08:11
@JasonYangShadow
Copy link
Member Author

@DrDaveD thanks for the comments, I've updated the PR

Copy link
Contributor

@DrDaveD DrDaveD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor things remain and a rebase due to merge conflict.

scripts/ci-deb-build-test Outdated Show resolved Hide resolved
scripts/ci-deb-build-test Outdated Show resolved Hide resolved
@DrDaveD DrDaveD added this to the 1.3.3 milestone Jun 18, 2024
@JasonYangShadow JasonYangShadow force-pushed the issue/2027 branch 2 times, most recently from ed9bcc3 to b729ce9 Compare June 19, 2024 01:05
@DrDaveD
Copy link
Contributor

DrDaveD commented Jun 19, 2024

Now this one has a merge conflict, sorry

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Signed-off-by: jason yang <jasonyangshadow@gmail.com>
@DrDaveD DrDaveD merged commit 5583ff9 into apptainer:main Jun 19, 2024
17 checks passed
@DrDaveD
Copy link
Contributor

DrDaveD commented Jun 19, 2024

Please also cherry-pick to release-1.3

@JasonYangShadow JasonYangShadow deleted the issue/2027 branch July 3, 2024 14:33
nsoranzo added a commit to nsoranzo/setup-apptainer that referenced this pull request Dec 17, 2024
nsoranzo added a commit to nsoranzo/galaxy that referenced this pull request Dec 17, 2024
(which started failing since ubuntu-latest was moved to 24.04)
by upgrading apptainer to >=1.3.3 to include
apptainer/apptainer#2262 .

Fix:

```
>       assert "samtools:1.0--1" in results["passed"], results
E       AssertionError:
E       {'failed': [{'commands': ['python -c "import pyBigWig; assert(pyBigWig.numpy '
E                                 '== 1); assert(pyBigWig.remote == 1)"'],
E                    'container': 'pybigwig:0.3.22--py36h54a71a5_0',
E                    'errors': [{'command': 'python -c "import pyBigWig; '
E                                           'assert(pyBigWig.numpy == 1); '
E                                           'assert(pyBigWig.remote == 1)"',
E                                'output': '\x1b[91mERROR  : Could not write info to '
E                                          'setgroups: Permission denied\n'
E                                          '\x1b[0m\x1b[91mERROR  : Error while '
E                                          'waiting event for user namespace mappings: '
E                                          'no event received\n'
E                                          '\x1b[0m'},
E                               {'import': 'pyBigWig',
E                                'output': '\x1b[91mERROR  : Could not write info to '
E                                          'setgroups: Permission denied\n'
E                                          '\x1b[0m\x1b[91mERROR  : Error while '
E                                          'waiting event for user namespace mappings: '
E                                          'no event received\n'
E                                          '\x1b[0m'}],
E                    'import_lang': 'python -c',
E                    'imports': ['pyBigWig']},
E                   {'commands': ['samtools view --help 2>&1 | grep Notes > /dev/null'],
E                    'container': 'samtools:1.0--1',
E                    'errors': [{'command': 'samtools view --help 2>&1 | grep Notes > '
E                                           '/dev/null',
E                                'output': '\x1b[91mERROR  : Could not write info to '
E                                          'setgroups: Permission denied\n'
E                                          '\x1b[0m\x1b[91mERROR  : Error while '
E                                          'waiting event for user namespace mappings: '
E                                          'no event received\n'
E                                          '\x1b[0m'}],
E                    'import_lang': 'python -c'}],
E        'notest': ['yasm:1.3.0--0'],
E        'passed': []}
E       assert 'samtools:1.0--1' in []
```

Also:
- Improve assertion messages to facilitate debugging
nsoranzo added a commit to nsoranzo/galaxy that referenced this pull request Dec 18, 2024
(which started failing since ubuntu-latest was moved to 24.04)
by upgrading apptainer to >=1.3.3 to include
apptainer/apptainer#2262 .

Fix:

```
>       assert "samtools:1.0--1" in results["passed"], results
E       AssertionError:
E       {'failed': [{'commands': ['python -c "import pyBigWig; assert(pyBigWig.numpy '
E                                 '== 1); assert(pyBigWig.remote == 1)"'],
E                    'container': 'pybigwig:0.3.22--py36h54a71a5_0',
E                    'errors': [{'command': 'python -c "import pyBigWig; '
E                                           'assert(pyBigWig.numpy == 1); '
E                                           'assert(pyBigWig.remote == 1)"',
E                                'output': '\x1b[91mERROR  : Could not write info to '
E                                          'setgroups: Permission denied\n'
E                                          '\x1b[0m\x1b[91mERROR  : Error while '
E                                          'waiting event for user namespace mappings: '
E                                          'no event received\n'
E                                          '\x1b[0m'},
E                               {'import': 'pyBigWig',
E                                'output': '\x1b[91mERROR  : Could not write info to '
E                                          'setgroups: Permission denied\n'
E                                          '\x1b[0m\x1b[91mERROR  : Error while '
E                                          'waiting event for user namespace mappings: '
E                                          'no event received\n'
E                                          '\x1b[0m'}],
E                    'import_lang': 'python -c',
E                    'imports': ['pyBigWig']},
E                   {'commands': ['samtools view --help 2>&1 | grep Notes > /dev/null'],
E                    'container': 'samtools:1.0--1',
E                    'errors': [{'command': 'samtools view --help 2>&1 | grep Notes > '
E                                           '/dev/null',
E                                'output': '\x1b[91mERROR  : Could not write info to '
E                                          'setgroups: Permission denied\n'
E                                          '\x1b[0m\x1b[91mERROR  : Error while '
E                                          'waiting event for user namespace mappings: '
E                                          'no event received\n'
E                                          '\x1b[0m'}],
E                    'import_lang': 'python -c'}],
E        'notest': ['yasm:1.3.0--0'],
E        'passed': []}
E       assert 'samtools:1.0--1' in []
```

Also:
- Improve assertion messages to facilitate debugging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppArmor profile needed on Ubuntu 24.04
2 participants