Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --nv, --rocm, --bind flags to build command. #5911

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

cclerget
Copy link
Collaborator

@cclerget cclerget commented Apr 8, 2021

Description of the Pull Request (PR):

Add --nv, --rocm, --bind flags to build command. Those are taking effect during build for both post and test sections.

This fixes or addresses the following GitHub issues:

Before submitting a PR, make sure you have done the following:

Attn: @singularity-maintainers

@cclerget cclerget added this to the 3.8.0 milestone Apr 8, 2021
@cclerget cclerget self-assigned this Apr 8, 2021
Copy link
Contributor

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, but could you add a basic test into:

https://github.com/hpcng/singularity/blob/master/e2e/gpu/gpu.go

... or in the build tests. Gated by require.Nvidia / require.Rocm?

@cclerget
Copy link
Collaborator Author

cclerget commented Apr 9, 2021

Looks reasonable to me, but could you add a basic test into:

https://github.com/hpcng/singularity/blob/master/e2e/gpu/gpu.go

... or in the build tests. Gated by require.Nvidia / require.Rocm?

Tests added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Allow --nv during build
2 participants